Scala Programming Language › liftweb

makeUtf8 and HttpServletRequest broken in new build???

Classic

List

Threaded

17 messages Options

exmbly

makeUtf8 and HttpServletRequest broken in new build???

I just got a type mismatch found error in LiftRules.early.append
(makeUtf8) in Boot.scala.

It's now looking for an net.liftweb.http.provider.HTTPRequest instead
of a javax.servlet.http.HttpServletRequest.

Is this a new change, and if so, where is the
net.liftweb.http.provider package?

Glenn...

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Lift" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---

Remove Ads

timn

Re: makeUtf8 and HttpServletRequest broken in new build???

There were changes made to remove the requirement for lift to run in a servlet container. See:

http://groups.google.com/group/liftweb/browse_thread/thread/a3486a7b9e9ffa40

On Mon, Aug 10, 2009 at 11:49 AM, glenn <[hidden email]> wrote:

I just got a type mismatch found error in LiftRules.early.append
(makeUtf8) in Boot.scala.

It's now looking for an net.liftweb.http.provider.HTTPRequest instead
of a javax.servlet.http.HttpServletRequest.

Is this a new change, and if so, where is the
net.liftweb.http.provider package?

Glenn...

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Lift" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---

Jeppe Nejsum Madsen

Re: makeUtf8 and HttpServletRequest broken in new build???

In reply to this post by exmbly

glenn <[hidden email]> writes:

> I just got a type mismatch found error in LiftRules.early.append
> (makeUtf8) in Boot.scala.
>
> It's now looking for an net.liftweb.http.provider.HTTPRequest instead
> of a javax.servlet.http.HttpServletRequest.
>
> Is this a new change, and if so, where is the
> net.liftweb.http.provider package?

Yes, this was announced on the mailing list a while a go.

The provider package is in lift-webkit

/Jeppe

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Lift" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---

exmbly

Re: makeUtf8 and HttpServletRequest broken in new build???

In reply to this post by timn

I realize the need to improve the code, but do you have to break
existing in
the process? That's bad form.

Glenn...

On Aug 10, 9:55 am, Tim Nelson <[hidden email]> wrote:

> There were changes made to remove the requirement for lift to run in a
> servlet container. See:
>
> http://groups.google.com/group/liftweb/browse_thread/thread/a3486a7b9...
>
> On Mon, Aug 10, 2009 at 11:49 AM, glenn <[hidden email]> wrote:
>
> > I just got a type mismatch found error in LiftRules.early.append
> > (makeUtf8) in Boot.scala.
>
> > It's now looking for an net.liftweb.http.provider.HTTPRequest instead
> > of a javax.servlet.http.HttpServletRequest.
>
> > Is this a new change, and if so, where is the
> > net.liftweb.http.provider package?
>
> > Glenn...

Dridus

Re: makeUtf8 and HttpServletRequest broken in new build???

It was well warned about (many capital letters and asterisks) and
you're clearly compiling against SNAPSHOTs. If you do not want new
features, but guaranteed unchanging API, then you should probably use
1.1 milestones or 1.0 instead.

-Ross

On Aug 10, 2009, at 1:05 PM, glenn wrote:

>
> I realize the need to improve the code, but do you have to break
> existing in
> the process? That's bad form.
>
> Glenn...
>
>
>
> On Aug 10, 9:55 am, Tim Nelson <[hidden email]> wrote:
>> There were changes made to remove the requirement for lift to run
>> in a
>> servlet container. See:
>>
>> http://groups.google.com/group/liftweb/browse_thread/thread/
>> a3486a7b9...
>>
>> On Mon, Aug 10, 2009 at 11:49 AM, glenn <[hidden email]> wrote:
>>
>>> I just got a type mismatch found error in LiftRules.early.append
>>> (makeUtf8) in Boot.scala.
>>
>>> It's now looking for an net.liftweb.http.provider.HTTPRequest
>>> instead
>>> of a javax.servlet.http.HttpServletRequest.
>>
>>> Is this a new change, and if so, where is the
>>> net.liftweb.http.provider package?
>>
>>> Glenn...
> >

dpp

Re: makeUtf8 and HttpServletRequest broken in new build???

In reply to this post by exmbly

On Mon, Aug 10, 2009 at 10:05 AM, glenn <[hidden email]> wrote:

I realize the need to improve the code, but do you have to break
existing in
the process? That's bad form.

The issue was discussed on list. The branch was available for inspection in the repository for > 1 month.

The warning about the API breakage was very well publicized including a message that included "**** BREAKING CHANGE****" in the title.

The API breakage was trivial (requiring the change in a few places in your code and caught by the compiler).

The reasons for the change were compelling (moving away from hard coding the Servlets, thus allowing support for non-JEE containers, Portlets, etc.)

The change has been on the 1.1 roadmap.

So, while I agree that breaking APIs is less than 100% optimal, it does happen from time to time and after significant discussion and warning.

Glenn...

On Aug 10, 9:55 am, Tim Nelson <[hidden email]> wrote:
> There were changes made to remove the requirement for lift to run in a
> servlet container. See:
>

> http://groups.google.com/group/liftweb/browse_thread/thread/a3486a7b9...

>
> On Mon, Aug 10, 2009 at 11:49 AM, glenn <[hidden email]> wrote:
>
> > I just got a type mismatch found error in LiftRules.early.append
> > (makeUtf8) in Boot.scala.
>
> > It's now looking for an net.liftweb.http.provider.HTTPRequest instead
> > of a javax.servlet.http.HttpServletRequest.
>
> > Is this a new change, and if so, where is the
> > net.liftweb.http.provider package?
>
> > Glenn...

--
Lift, the simply functional web framework http://liftweb.net
Beginning Scala http://www.apress.com/book/view/1430219890
Follow me: http://twitter.com/dpp
Git some: http://github.com/dpp

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Lift" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---

Marius Danciu

Re: makeUtf8 and HttpServletRequest broken in new build???

In reply to this post by exmbly

Your makeUTF8 should look like this:

private def makeUtf8(req: HTTPRequest): Unit =
{req.setCharacterEncoding("UTF-8")}

just use HTTPRequest instead of HttpServletRequest.

Br's,
Marius

On Aug 10, 7:49 pm, glenn <[hidden email]> wrote:

> I just got a type mismatch found error in LiftRules.early.append
> (makeUtf8) in Boot.scala.
>
> It's now looking for an net.liftweb.http.provider.HTTPRequest instead
> of a javax.servlet.http.HttpServletRequest.
>
> Is this a new change, and if so, where is the
> net.liftweb.http.provider package?
>
> Glenn...

exmbly

Re: makeUtf8 and HttpServletRequest broken in new build???

Is anyone planning on fixing the archetype snapshots to add
this change, and "import provider._" in Boot.scala.

Thanks in advance,

Glenn...

On Aug 10, 10:36 am, "marius d." <[hidden email]> wrote:

> Your makeUTF8 should look like this:
>
> private def makeUtf8(req: HTTPRequest): Unit =
> {req.setCharacterEncoding("UTF-8")}
>
> just use HTTPRequest instead of HttpServletRequest.
>
> Br's,
> Marius
>
> On Aug 10, 7:49 pm, glenn <[hidden email]> wrote:
>
> > I just got a type mismatch found error in LiftRules.early.append
> > (makeUtf8) in Boot.scala.
>
> > It's now looking for an net.liftweb.http.provider.HTTPRequest instead
> > of a javax.servlet.http.HttpServletRequest.
>
> > Is this a new change, and if so, where is the
> > net.liftweb.http.provider package?
>
> > Glenn...

dpp

Re: makeUtf8 and HttpServletRequest broken in new build???

On Mon, Aug 17, 2009 at 9:42 AM, glenn <[hidden email]> wrote:

Is anyone planning on fixing the archetype snapshots to add
this change, and "import provider._" in Boot.scala.

I'm able to create a new "Basic" Lift app from archetypes... and it works just fine. Can you tell us what command you typed to get an archetype that did not work?

Thanks in advance,

Glenn...

On Aug 10, 10:36 am, "marius d." <[hidden email]> wrote:
> Your makeUTF8 should look like this:
>
> private def makeUtf8(req: HTTPRequest): Unit =
> {req.setCharacterEncoding("UTF-8")}
>
> just use HTTPRequest instead of HttpServletRequest.
>
> Br's,
> Marius
>
> On Aug 10, 7:49 pm, glenn <[hidden email]> wrote:
>
> > I just got a type mismatch found error in LiftRules.early.append
> > (makeUtf8) in Boot.scala.
>
> > It's now looking for an net.liftweb.http.provider.HTTPRequest instead
> > of a javax.servlet.http.HttpServletRequest.
>
> > Is this a new change, and if so, where is the
> > net.liftweb.http.provider package?
>
> > Glenn...

Timothy Perrett

Re: makeUtf8 and HttpServletRequest broken in new build???

Re: [Lift] Re: makeUtf8 and HttpServletRequest broken in new build???
I think his point is that he wants it added by default, rather than there is any problem. Personally, I don’t see the point of adding it by default... But hey.

On this note, I’ve been thinking of perhaps having a re-shuffle in the code base to group the archetypes together in a module and add a bunch of other archetypes for various things such as:

PayPal
Akka
AMQP
Etc.

Thoughts?

Cheers, Tim

On 17/08/2009 18:10, "David Pollak" <feeder.of.the.bears@...> wrote:

I'm able to create a new "Basic" Lift app from archetypes... and it works just fine. Can you tell us what command you typed to get an archetype that did not work?

dpp

Re: makeUtf8 and HttpServletRequest broken in new build???

On Mon, Aug 17, 2009 at 3:32 PM, Timothy Perrett <[hidden email]> wrote:

I think his point is that he wants it added by default, rather than there is any problem. Personally, I don’t see the point of adding it by default... But hey.

It is done by default in the Basic archetype.

On this note, I’ve been thinking of perhaps having a re-shuffle in the code base to group the archetypes together in a module and add a bunch of other archetypes for various things such as:

PayPal
Akka
AMQP
Etc.

Thoughts?

As long as you don't mess with the Basic archetype... I'm cool.

Cheers, Tim

On 17/08/2009 18:10, "David Pollak" <feeder.of.the.bears@...> wrote:

I'm able to create a new "Basic" Lift app from archetypes... and it works just fine. Can you tell us what command you typed to get an archetype that did not work?

Timothy Perrett

Re: makeUtf8 and HttpServletRequest broken in new build???

Re: [Lift] Re: makeUtf8 and HttpServletRequest broken in new build???
They would still output the same of course – I just see a need for a few more starting points and I don’t want to clutter the main codebase so a little bit of housekeeping is in order :-)

Cheers, Tim

On 17/08/2009 23:43, "David Pollak" <feeder.of.the.bears@...> wrote:

As long as you don't mess with the Basic archetype... I'm cool.

Indrajit Raychaudhuri

Re: makeUtf8 and HttpServletRequest broken in new build???

+1 on some amount of nesting and reorganization.
For example: docs, lift-archetype-basic, lift-facebook, lift-installer
are all too different to be peers and probably can have different home
(nested) based on 'traits' :)

Cheers,
Indrajit

On Aug 18, 3:51 am, Timothy Perrett <[hidden email]> wrote:
> They would still output the same of course I just see a need for a few
> more starting points and I don¹t want to clutter the main codebase so a
> little bit of housekeeping is in order :-)
>
> Cheers, Tim
>
> On 17/08/2009 23:43, "David Pollak" <[hidden email]> wrote:
>
> > As long as you don't mess with the Basic archetype... I'm cool.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Lift" group.
To post to this group, send email to [hidden email]
To unsubscribe from this group, send email to [hidden email]
For more options, visit this group at http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---

exmbly

Re: makeUtf8 and HttpServletRequest broken in new build???

In reply to this post by dpp

David,

I just ran the basic from SNAPSHOTS and Boot.scala still has

private def makeUtf8(req: HttpServletRequest) {
req.setCharacterEncoding("UTF-8")
}

in Boot.scala.

Glenn...

On Aug 17, 10:10 am, David Pollak <[hidden email]>
wrote:

> On Mon, Aug 17, 2009 at 9:42 AM, glenn <[hidden email]> wrote:
>
> > Is anyone planning on fixing the archetype snapshots to add
> > this change, and "import provider._" in Boot.scala.
>
> I'm able to create a new "Basic" Lift app from archetypes... and it works
> just fine. Can you tell us what command you typed to get an archetype that
> did not work?
>
>
>
>
>
> > Thanks in advance,
>
> > Glenn...
>
> > On Aug 10, 10:36 am, "marius d." <[hidden email]> wrote:
> > > Your makeUTF8 should look like this:
>
> > > private def makeUtf8(req: HTTPRequest): Unit =
> > > {req.setCharacterEncoding("UTF-8")}
>
> > > just use HTTPRequest instead of HttpServletRequest.
>
> > > Br's,
> > > Marius
>
> > > On Aug 10, 7:49 pm, glenn <[hidden email]> wrote:
>
> > > > I just got a type mismatch found error in LiftRules.early.append
> > > > (makeUtf8) in Boot.scala.
>
> > > > It's now looking for an net.liftweb.http.provider.HTTPRequest instead
> > > > of a javax.servlet.http.HttpServletRequest.
>
> > > > Is this a new change, and if so, where is the
> > > > net.liftweb.http.provider package?
>
> > > > Glenn...
>
> --
> Lift, the simply functional web frameworkhttp://liftweb.net
> Beginning Scalahttp://www.apress.com/book/view/1430219890
> Follow me:http://twitter.com/dpp
> Git some:http://github.com/dpp

dpp

Re: makeUtf8 and HttpServletRequest broken in new build???

On Tue, Aug 18, 2009 at 9:15 AM, glenn <[hidden email]> wrote:

David,

I just ran the basic from SNAPSHOTS and Boot.scala still has

What did you type at the command line?

private def makeUtf8(req: HttpServletRequest) {
req.setCharacterEncoding("UTF-8")
}

in Boot.scala.

Glenn...

On Aug 17, 10:10 am, David Pollak <[hidden email]>
wrote:

> On Mon, Aug 17, 2009 at 9:42 AM, glenn <[hidden email]> wrote:
>
> > Is anyone planning on fixing the archetype snapshots to add
> > this change, and "import provider._" in Boot.scala.
>
> I'm able to create a new "Basic" Lift app from archetypes... and it works
> just fine. Can you tell us what command you typed to get an archetype that
> did not work?
>
>
>
>
>
> > Thanks in advance,
>
> > Glenn...
>
> > On Aug 10, 10:36 am, "marius d." <[hidden email]> wrote:
> > > Your makeUTF8 should look like this:
>
> > > private def makeUtf8(req: HTTPRequest): Unit =
> > > {req.setCharacterEncoding("UTF-8")}
>
> > > just use HTTPRequest instead of HttpServletRequest.
>
> > > Br's,
> > > Marius
>
> > > On Aug 10, 7:49 pm, glenn <[hidden email]> wrote:
>
> > > > I just got a type mismatch found error in LiftRules.early.append
> > > > (makeUtf8) in Boot.scala.
>
> > > > It's now looking for an net.liftweb.http.provider.HTTPRequest instead
> > > > of a javax.servlet.http.HttpServletRequest.
>
> > > > Is this a new change, and if so, where is the
> > > > net.liftweb.http.provider package?
>
> > > > Glenn...
>
> --

> Lift, the simply functional web frameworkhttp://liftweb.net

> Beginning Scalahttp://www.apress.com/book/view/1430219890

> Follow me:http://twitter.com/dpp
> Git some:http://github.com/dpp

exmbly

Re: makeUtf8 and HttpServletRequest broken in new build???

Actually, I used the Maven Eclipse plugin. File/New/Other/Maven/Maven
Project.
Click <Next> twice and select the Nexus Indexer Archetype catalog. Use
lift to
filter and select

Group Id: repository.net.liftweb
Artifact Id: lift.archetype.basic
Version: 1.1-SNAPSHOT

Glenn...

On Aug 18, 10:32 am, David Pollak <[hidden email]>
wrote:

> On Tue, Aug 18, 2009 at 9:15 AM, glenn <[hidden email]> wrote:
>
> > David,
>
> > I just ran the basic from SNAPSHOTS and Boot.scala still has
>
> What did you type at the command line?
>
>
>
>
>
> > private def makeUtf8(req: HttpServletRequest) {
> > req.setCharacterEncoding("UTF-8")
> > }
>
> > in Boot.scala.
>
> > Glenn...
>
> > On Aug 17, 10:10 am, David Pollak <[hidden email]>
> > wrote:
> > > On Mon, Aug 17, 2009 at 9:42 AM, glenn <[hidden email]> wrote:
>
> > > > Is anyone planning on fixing the archetype snapshots to add
> > > > this change, and "import provider._" in Boot.scala.
>
> > > I'm able to create a new "Basic" Lift app from archetypes... and it works
> > > just fine. Can you tell us what command you typed to get an archetype
> > that
> > > did not work?
>
> > > > Thanks in advance,
>
> > > > Glenn...
>
> > > > On Aug 10, 10:36 am, "marius d." <[hidden email]> wrote:
> > > > > Your makeUTF8 should look like this:
>
> > > > > private def makeUtf8(req: HTTPRequest): Unit =
> > > > > {req.setCharacterEncoding("UTF-8")}
>
> > > > > just use HTTPRequest instead of HttpServletRequest.
>
> > > > > Br's,
> > > > > Marius
>
> > > > > On Aug 10, 7:49 pm, glenn <[hidden email]> wrote:
>
> > > > > > I just got a type mismatch found error in LiftRules.early.append
> > > > > > (makeUtf8) in Boot.scala.
>
> > > > > > It's now looking for an net.liftweb.http.provider.HTTPRequest
> > instead
> > > > > > of a javax.servlet.http.HttpServletRequest.
>
> > > > > > Is this a new change, and if so, where is the
> > > > > > net.liftweb.http.provider package?
>
> > > > > > Glenn...
>
> > > --
> > > Lift, the simply functional web frameworkhttp://liftweb.net
> > > Beginning Scalahttp://www.apress.com/book/view/1430219890
> > > Follow me:http://twitter.com/dpp
> > > Git some:http://github.com/dpp
>
> --
> Lift, the simply functional web frameworkhttp://liftweb.net
> Beginning Scalahttp://www.apress.com/book/view/1430219890
> Follow me:http://twitter.com/dpp
> Git some:http://github.com/dpp

dpp

Re: makeUtf8 and HttpServletRequest broken in new build???

When executed from the command line, the result is a working app. I think it's a problem with the Maven plugin or a stale cache.

On Tue, Aug 18, 2009 at 2:26 PM, glenn <[hidden email]> wrote:

Actually, I used the Maven Eclipse plugin. File/New/Other/Maven/Maven
Project.
Click <Next> twice and select the Nexus Indexer Archetype catalog. Use
lift to
filter and select

Group Id: repository.net.liftweb
Artifact Id: lift.archetype.basic
Version: 1.1-SNAPSHOT

Glenn...

On Aug 18, 10:32 am, David Pollak <[hidden email]>
wrote:

> On Tue, Aug 18, 2009 at 9:15 AM, glenn <[hidden email]> wrote:
>
> > David,
>
> > I just ran the basic from SNAPSHOTS and Boot.scala still has
>
> What did you type at the command line?
>
>
>
>
>
> > private def makeUtf8(req: HttpServletRequest) {
> > req.setCharacterEncoding("UTF-8")
> > }
>
> > in Boot.scala.
>
> > Glenn...
>
> > On Aug 17, 10:10 am, David Pollak <[hidden email]>
> > wrote:
> > > On Mon, Aug 17, 2009 at 9:42 AM, glenn <[hidden email]> wrote:
>
> > > > Is anyone planning on fixing the archetype snapshots to add
> > > > this change, and "import provider._" in Boot.scala.
>
> > > I'm able to create a new "Basic" Lift app from archetypes... and it works
> > > just fine. Can you tell us what command you typed to get an archetype
> > that
> > > did not work?
>
> > > > Thanks in advance,
>
> > > > Glenn...
>
> > > > On Aug 10, 10:36 am, "marius d." <[hidden email]> wrote:
> > > > > Your makeUTF8 should look like this:
>
> > > > > private def makeUtf8(req: HTTPRequest): Unit =
> > > > > {req.setCharacterEncoding("UTF-8")}
>
> > > > > just use HTTPRequest instead of HttpServletRequest.
>
> > > > > Br's,
> > > > > Marius
>
> > > > > On Aug 10, 7:49 pm, glenn <[hidden email]> wrote:
>
> > > > > > I just got a type mismatch found error in LiftRules.early.append
> > > > > > (makeUtf8) in Boot.scala.
>
> > > > > > It's now looking for an net.liftweb.http.provider.HTTPRequest
> > instead
> > > > > > of a javax.servlet.http.HttpServletRequest.
>
> > > > > > Is this a new change, and if so, where is the
> > > > > > net.liftweb.http.provider package?
>
> > > > > > Glenn...
>
> > > --
> > > Lift, the simply functional web frameworkhttp://liftweb.net
> > > Beginning Scalahttp://www.apress.com/book/view/1430219890
> > > Follow me:http://twitter.com/dpp
> > > Git some:http://github.com/dpp
>
> --
> Lift, the simply functional web frameworkhttp://liftweb.net
> Beginning Scalahttp://www.apress.com/book/view/1430219890
> Follow me:http://twitter.com/dpp
> Git some:http://github.com/dpp